Logs middleware #116
Open
Logs middleware #116
+368
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 9 +1
Lines 273 356 +83
Branches 48 65 +17
=========================================
+ Hits 273 356 +83
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
pachCode
reviewed
Aug 1, 2022
|
|
||
| @pytest.fixture(autouse=True) | ||
| def patch_log_server_url(monkeypatch): | ||
| monkeypatch.setenv('LOGS_SERVER_URL', 'http://logs.com') |
pachCode
reviewed
Aug 1, 2022
| async def dispatch( | ||
| self, request: Request, call_next: RequestResponseEndpoint | ||
| ) -> Response: | ||
| if not os.environ.get('LOGS_SERVER_URL', ''): |
There was a problem hiding this comment.
porque se manda a llamar dentro de la función y no como una variable global?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements a middleware that sends requests information to a log ingestion server (Logstash)